Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PythonMutator: Add tests for import #1789

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/push.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: '3.9'
python-version: '3.10'

- name: Set go env
run: |
Expand Down
15 changes: 15 additions & 0 deletions bundle/tests/python_import/dataclass_no_wheel/databricks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
bundle:
name: python-import-dataclass-no-wheel

experimental:
pydabs:
enabled: true
import:
- "my_job"

variables:
default_cluster_spec:
type: complex
value:
num_workers: 1
spark_version: "15.4.x-scala2.12"
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Databricks Notebook Source
1+1
22 changes: 22 additions & 0 deletions bundle/tests/python_import/dataclass_no_wheel/src/my_job.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
from databricks.bundles.jobs import Job, Task, NotebookTask, JobCluster
from databricks.bundles.variables import Bundle

my_job = Job(
name="Test Job",
resource_name="my_job",
job_clusters=[
JobCluster(
job_cluster_key="my_cluster",
new_cluster=Bundle.variables.default_cluster_spec,
),
],
tasks=[
Task(
task_key="my_notebook_task",
job_cluster_key="my_cluster",
notebook_task=NotebookTask(
notebook_path="notebooks/my_notebook.py",
),
),
],
)
95 changes: 95 additions & 0 deletions bundle/tests/python_import_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
package config_tests

import (
"os"
"os/exec"
pathlib "path"
"runtime"
"testing"

"github.com/databricks/cli/bundle/config/resources"
"github.com/databricks/cli/libs/dyn"
"github.com/databricks/databricks-sdk-go/service/jobs"
"github.com/stretchr/testify/require"
"golang.org/x/exp/maps"

"github.com/stretchr/testify/assert"
)

func TestPythonImport_dataclass_no_wheel(t *testing.T) {
activateVEnv(t)
setPythonPath(t, "python_import/dataclass_no_wheel/src")

expected := &resources.Job{
JobSettings: &jobs.JobSettings{
Name: "Test Job",
JobClusters: []jobs.JobCluster{
{
JobClusterKey: "my_cluster",
},
},
Tasks: []jobs.Task{
{
NotebookTask: &jobs.NotebookTask{
NotebookPath: "notebooks/my_notebook.py",
},
JobClusterKey: "my_cluster",
TaskKey: "my_notebook_task",
},
},
},
}

b := load(t, "./python_import/dataclass_no_wheel")

assert.Equal(t, []string{"my_job"}, maps.Keys(b.Config.Resources.Jobs))

myJob := b.Config.Resources.Jobs["my_job"]
assert.Equal(t, expected, myJob)

// NewCluster is reference to a variable and needs to be checked separately
err := b.Config.Mutate(func(value dyn.Value) (dyn.Value, error) {
path := dyn.MustPathFromString("resources.jobs.my_job.job_clusters[0].new_cluster")
value, err := dyn.GetByPath(value, path)
if err != nil {
return dyn.InvalidValue, err
}

assert.Equal(t, "${var.default_cluster_spec}", value.AsAny())

return value, nil
})
require.NoError(t, err)
}

func setPythonPath(t *testing.T, path string) {
wd, err := os.Getwd()
require.NoError(t, err)
t.Setenv("PYTHONPATH", pathlib.Join(wd, path))
}

func activateVEnv(t *testing.T) {
dir := t.TempDir()
venvDir := pathlib.Join(dir, "venv")

err := exec.Command("python3", "-m", "venv", venvDir).Run()
require.NoError(t, err, "failed to create venv")

// we don't have shell to activate venv, updating PATH is enough

var venvBinDir string
if runtime.GOOS == "windows" {
venvBinDir = pathlib.Join(venvDir, "Scripts")
t.Setenv("PATH", venvBinDir+";"+os.Getenv("PATH"))
} else {
venvBinDir = pathlib.Join(venvDir, "bin")
t.Setenv("PATH", venvBinDir+":"+os.Getenv("PATH"))
}

err = exec.Command(
pathlib.Join(venvBinDir, "pip"),
"install",
"databricks-pydabs==0.5.1",
).Run()
require.NoError(t, err, "failed to install databricks-pydabs")
}