Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example of Databricks Apps which manages a job created by the same bundle #48

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Example of Databricks Apps which manages a job created by the same bundle #48

wants to merge 1 commit into from
+128 −0

Conversation

andrewnester
Copy link
Contributor

WIP

@andrewnester andrewnester requested a review from pietern November 28, 2024 13:33
lennartkats-db
lennartkats-db approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@lennartkats-db lennartkats-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this example! Minor comments.

knowledge_base/databricks_app/resources/app_job.job.yml
@@ -0,0 +1,16 @@
resources:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

app_job.job.yml seems a bit redundant, could you give this a different name?

knowledge_base/databricks_app/resources/app_job.job.yml
spec:
client: "1"
dependencies:
- cowsay
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking, but something to keep in mind: cowsay has a copyleft license

knowledge_base/databricks_app/resources/job_manager.app.yml
valueFrom: "app-job"

# The resources which this app have an access to.
resources:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope for this PR: we really need to find a different name for this property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lennartkats-db lennartkats-db lennartkats-db approved these changes

@pietern pietern Awaiting requested review from pietern

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewnester @lennartkats-db