Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inner dev loop fixes #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Inner dev loop fixes #18

wants to merge 2 commits into from

Conversation

fjakobs
Copy link

@fjakobs fjakobs commented Jan 23, 2024

  1. Add dlt typing
  2. Add auto reload to the notebook
  3. Pass in spark object to library so it works better with DBConnect in the IDE

Copy link
Contributor

@lennartkats-db lennartkats-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions!! Please see the comments inline.

And note that the source of truth here is the default-python template in the CLI repository. Any changes should be committed there.

default_python/requirements-dev.txt Outdated Show resolved Hide resolved
default_python/src/default_python/main.py Show resolved Hide resolved
default_python/src/notebook.ipynb Show resolved Hide resolved
@fjakobs
Copy link
Author

fjakobs commented Feb 27, 2024

@lennartkats-db I made a related PR for the default python template databricks/cli#1239

@@ -3,6 +3,9 @@
## For defining dependencies used by jobs in Databricks Workflows, see
## https://docs.databricks.com/dev-tools/bundles/library-dependencies.html

## Add code completion support for DLT
databricks-dlt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have this, would it be possible/desirable to enable python.analysis.typeCheckingMode"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants