Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added implementation of https://eprint.iacr.org/2024/1077 #1449

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sandy9999
Copy link

Added implementation of the Decision Tree protocol from "Securely Training Decision Trees Efficiently" by Divyanshu Bhardwaj, Sandhya Saravanan, Nishanth Chandran and Divya Gupta : eprint link.

This decision tree training protocol has communication complexity $O(mN \log N + hmN + hN \log N)$ which is an improvement of $\approx min(h, m, \log N)$ over Hamada et. al link.

-Sandhya Saravanan

@mkskeller
Copy link
Member

Thank you for submitting this pull request. However, the code isn't suitable for inclusion due to the following reasons:

  • Using the code fails with an indentation error
  • If the error is corrected, it fails because radix_sort_permutation_from_matrix is not available
  • I don't see a good reason for a separate module if the functionality it provides is essentially the same as an existing module
  • decision_tree_new is not a meaningful name and will be even less meaningful as time goes on
  • Multiple functions are just copy-pasted instead of imported. This is bad practice as future improvements to them will go unused.

I would suggest the following apart from correcting the compilation errors:

  • Add the code to the decision_tree module where it can be found by users.
  • Avoid using "new" as prefix or suffix. Use either "optimized" or something more prescriptive.
  • Avoid the use of entirely copy-pasted functions.
  • Consider sub-classing the existing classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants