[Plugin-1730] Adding XLS UI elements for S3 source #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DJSagarAhire
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Most comments from data-integrations/google-cloud#1368 are also applicable here. Looks good apart from those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding XLS UI elements for S3 source
Jira : Plugin-1730
Description
This PR adds UI element required for XLS Support in
S3 Source.Ref : XLS Support PR cdapio/hydrator-plugins#1835
Added Fields
A filter is used to show XLS specific values
Terminate If Empty Row,Select Sheet Using,Sheet Valueonly when formatXLSis selected.Preview