Robuster deeply nested structures #8730
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8700
The reason why I said that those tests are not great is because the thresholds were arbitrary and therefore dependent on CPython, pytest and dask code.
This changes the way the deeply nested structure is generated in a way that it generates a structure that is multiple times that of the recursion depth so every attempt to dive into this will inevitably fail with a recursion error.
It works... but python3.12 is horribly slow. I haven't profiled this, yet. On py3.10 this runs in about 0.1s while on py3.12 this runs for 20-30s. This worries me for two reasons
I haven't run any profiles yet (mostly because pyspy doesn't work on python3.12) but I welcome anybody else to peak into this