Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update make_tls_certs.py, work with openssl 3 (#8701) #8707

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update make_tls_certs.py, work with openssl 3 (#8701) #8707

wants to merge 1 commit into from
+808 −514

Commits on Jun 19, 2024

  1. Update make_tls_certs.py, work with openssl 3 (dask#8701) 

    make_tls_certs.py has not been updated significantly since 2018,
and the certs it generates are not good enough for openssl 3:

E           ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Basic Constraints of CA cert not marked critical (_ssl.c:1020)

This resyncs the generation script with the current version of
cpython's make_ssl_certs.py, on which it is based. I dropped
various superficial changes which were made (wrapping, spacing,
quote style), because they make diffing it against the original
to see what's *really* different unnecessarily hard.

This also updates all the certificates, of course, which makes
the tests work against openssl 3.

Signed-off-by: Adam Williamson <[email protected]>
    @AdamWill
    AdamWill committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    221875f View commit details
    Browse the repository at this point in the history