Skip to content

Commit

Permalink
Changing <All Time> label and hint (#36)
Browse files Browse the repository at this point in the history
The original title “All time” and the hint “Messages since start” could be ambiguous for users trying to understand what the statistics represent. Changing the title to “Successful” and clarifying the hint helps users better understand the metrics being displayed, making the UI more user-friendly.
  • Loading branch information
mustela authored Oct 3, 2024
1 parent a5207de commit ea86bc6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion lib/broadway_dashboard.ex
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ defmodule BroadwayDashboard do
<:col>
<.row>
<:col>
<.card title="All time" hint="Messages since start." inner_title="successful"><%= @stats.successful %></.card>
<.card title="Successful" hint="Messages since the BroadwayDashboard page was first mounted." inner_title="successful"><%= @stats.successful %></.card>
</:col>
<:col>
<.card inner_title="failed"><%= @stats.failed %></.card>
Expand Down
4 changes: 2 additions & 2 deletions test/broadway_dashboard_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ defmodule BroadwayDashboardTest do
rendered = render(live)
assert rendered =~ "Updates automatically"
assert rendered =~ "Throughput"
assert rendered =~ "All time"
assert rendered =~ "Successful"
end

test "auto discover is enabled when pipeline is registered using via" do
Expand Down Expand Up @@ -131,7 +131,7 @@ defmodule BroadwayDashboardTest do
rendered = render(live)
assert rendered =~ "Updates automatically"
assert rendered =~ "Throughput"
assert rendered =~ "All time"
assert rendered =~ "Successful"

assert rendered =~ "prod_0"

Expand Down

0 comments on commit ea86bc6

Please sign in to comment.