Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrement the reference count on the invocation object in _method_callback #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Decrement the reference count on the invocation object in _method_callback #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dasbus/server/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,8 @@ def _method_callback(self, invocation, interface_name, method_name,
method_name,
error
)
finally:
invocation._unref()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a bug in pygobject. Python libraries shouldn't deal with references. I never saw unreferencing in pydbus and it is definitely not happening in dasbus. Could you please report your issue to https://gitlab.gnome.org/GNOME/pygobject?


def _get_additional_arguments(self, invocation, interface_name,
method_name, parameters):
Expand Down