Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issue #98 added splashscreen #144

Closed

Conversation

Ashurajput02
Copy link

@Ashurajput02 Ashurajput02 commented Mar 16, 2024

Pull Request Title

feat(clnapp): fixes issue #98

Description

1.Added a SplashScreen which runs fine on both Iphone and Android.
2.Updated the kotlin version to the latest one under Android/gradle

Checklist

  • I have tested my changes
  • I have updated the documentation
  • I have added necessary comments

Screenshots (if applicable)

Android:

androidtest.mp4

Iphone:
Simulator Screenshot - iPhone 15 Pro Max - 2024-03-16 at 15 46 41
Simulator Screenshot - iPhone 15 Pro Max - 2024-03-16 at 15 46 39


Commits

  • feat(clnapp): fixes issue #98
    • Added a splash screen in the app .
    • The splash screen now consists of the app logo, a cool tagline on a light blue background.

Copy link

netlify bot commented Mar 16, 2024

Deploy Preview for clnapp ready!

Name Link
🔨 Latest commit e7310ef
🔍 Latest deploy log https://app.netlify.com/sites/clnapp/deploys/65f576cfac1a880008e748d0
😎 Deploy Preview https://deploy-preview-144--clnapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vincenzopalazzo
Copy link
Member

The splesh screen need to respect our theme color

@Ashurajput02
Copy link
Author

The splesh screen need to respect our theme color

So,I need to change:
1.the background color from Light Blue to backgroundColor: Theme.of(context).colorScheme.background,
2.and the text color from white to default.

Between is the tag line good?

@Ashurajput02
Copy link
Author

The splesh screen need to respect our theme color

Screenrecorder-2024-03-19-15-25-37-377.mp4

This will be the result after making the changes in color from sky blue to primary background
Hope this one matches CLN app's theme

@vincenzopalazzo
Copy link
Member

on the web is still blue https://deploy-preview-144--clnapp.netlify.app/

@Ashurajput02
Copy link
Author

Ashurajput02 commented Mar 19, 2024

Yes because I have not yet pushed the changes . I just thought to ask is this one perfect so that I can create a fresh pull request for the same

So if this now seems cool and correct then I can make a fresh PR with the changes involved
I have it on my system right now

@vincenzopalazzo
Copy link
Member

idk I still do not like how it looks, it is a standard usage of the splash screen

@Ashurajput02
Copy link
Author

.

idk I still do not like how it looks, it is a standard usage of the splash screen

May be we can use an animated spark coming down instead of a simple logo of the app.
I mean instead of simple logo, it comes as an animated spark of electricity and then comes the test after a delay And then a circle showing loading.

@vincenzopalazzo
Copy link
Member

I do not want to add a splash screen at this moment because the application UI sucks anyway. So I am closing this PR because there are issue more important to fix.

Thanks for contributing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants