-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue #98 added splashscreen #144
Fixes issue #98 added splashscreen #144
Conversation
✅ Deploy Preview for clnapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The splesh screen need to respect our theme color |
So,I need to change: Between is the tag line good? |
Screenrecorder-2024-03-19-15-25-37-377.mp4This will be the result after making the changes in color from sky blue to primary background |
on the web is still blue https://deploy-preview-144--clnapp.netlify.app/ |
Yes because I have not yet pushed the changes . I just thought to ask is this one perfect so that I can create a fresh pull request for the same So if this now seems cool and correct then I can make a fresh PR with the changes involved |
idk I still do not like how it looks, it is a standard usage of the splash screen |
.
May be we can use an animated spark coming down instead of a simple logo of the app. |
176d4dd
to
93e980e
Compare
I do not want to add a splash screen at this moment because the application UI sucks anyway. So I am closing this PR because there are issue more important to fix. Thanks for contributing |
Pull Request Title
feat(clnapp): fixes issue #98
Description
1.Added a SplashScreen which runs fine on both Iphone and Android.
2.Updated the kotlin version to the latest one under Android/gradle
Checklist
Screenshots (if applicable)
Android:
androidtest.mp4
Iphone:
Commits
feat(clnapp): fixes issue #98