-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor list and map mutations #94
Refactor list and map mutations #94
Conversation
@jonasfj it could be argued that the code that finally does the adjustment of the For list mutations: For map mutations: Is it " |
This PR improves #90 by:
skipAndExtractComments
:reclaimIndentAndLineBreak
function for taking back indent greedily consumed byskipAndExtractComments
when removing an element or entry within aYamlList
orYamlMap
respectively.skipAndExtractComments
andreclaimIndentAndLineBreak
which include:_appendToBlockList
and_removeFromBlockList
in lists._removeFromBlockMap
in maps.Completely aligns the changes from #90 and #93 with existing
YamlEditor
behaviour.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.