[dwds] Add unbatching retry mechanism for failing batched expression evals #2552
+54
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Worth noting I patched this into Flutter tools to verify it fixed the attached issue. |
bkonyi
reviewed
Dec 20, 2024
|
Added a test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a single subexpression throws in a batched request, the whole batch fails. DevTools is using this API to evaluate all the fields/getters on an Object. If any of those getters throw, all the queried members fail to show information.
Instead if the initial batched request fails we can retry each request as individual expression evals. This will correctly surface errors for the subexpression that throws and the proper values for all the other subexpressions.
See #2551