Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few diagnostics in anticipation of lints v5 #2525

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fix a few diagnostics in anticipation of lints v5 #2525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
afd95da
Fix a few diagnostics in anticipation of lints v5
parlough Nov 22, 2024
5f1b751
Merge branch 'main' into fix/upcoming-lint-fixes
parlough Dec 3, 2024
c49579d
Merge branch 'main' into fix/upcoming-lint-fixes
parlough Dec 5, 2024
020e0fc
Merge branch 'main' into fix/upcoming-lint-fixes
parlough Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dwds/lib/src/debugging/inspector.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -687,7 +687,8 @@ class AppInspector implements AppInspectorInterface {
return _instanceHelper.metadataHelper.isNativeJsError(instanceRef.classRef);
}

/// Request and cache <ScriptRef>s for all the scripts in the application.
/// Request and cache `<ScriptRef>` tags for all the
/// scripts in the application.
///
/// This populates [_scriptRefsById], [_scriptIdToLibraryId],
/// [_libraryIdToScriptRefs] and [_serverPathToScriptRef].
Expand Down
4 changes: 2 additions & 2 deletions dwds/lib/src/debugging/metadata/class.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,15 @@ class ClassMetaData {

/// Type name for Type instances.
///
/// For example, 'int', 'String', 'MyClass', 'List<int>'.
/// For example: `'int'`, `'String'`, `'MyClass'`, `'List<int>'`.
final String? typeName;

/// The length of the object, if applicable.
final int? length;

/// The dart type name for the object.
///
/// For example, 'int', 'List<String>', 'Null'
/// For example: `'int'`, `'List<String>'`, `'Null'`.
String? get dartName => classRef.name;

/// Class ref for the class metadata.
Expand Down
2 changes: 1 addition & 1 deletion dwds/lib/src/readers/asset_reader.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import 'package:package_config/package_config.dart';
abstract class AssetReader {
/// Base path of the application, for example, set up in the index file:
///
/// ```
/// ```html
/// <html>
/// <head>
/// <base href="/abc/">
Expand Down
5 changes: 3 additions & 2 deletions dwds/lib/src/services/expression_evaluator.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,11 @@ class ExpressionEvaluator {
static final _syntheticNameFilterRegex =
RegExp('org-dartlang-debug:synthetic_debug_expression:.*:.*Error: ');

/// Find module path from the XHR call network error message received from chrome.
/// Find module path from the XHR call network error message
/// received from chrome.
///
/// Example:
/// NetworkError: Failed to load 'http://<hostname>.com/path/to/module.js?<cache_busting_token>'
/// `NetworkError: Failed to load 'http://<hostname>.com/path/to/module.js?<cache_busting_token>'`
static final _loadModuleErrorRegex =
RegExp(r".*Failed to load '.*\.com/(.*\.js).*");

Expand Down
4 changes: 2 additions & 2 deletions dwds/test/fixtures/project.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ class TestProject {
),
);

/// The URI for the package_config.json is located in:
/// <project directory>/.dart_tool/package_config
/// The URI for the `package_config.json` is located in:
/// `<project directory>/.dart_tool/package_config`.
Uri get packageConfigFile => p.toUri(
p.join(
absolutePackageDirectory,
Expand Down
Loading