Delete directories between workspace package and workspace root #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasfj
reviewed
Nov 26, 2024
jonasfj
approved these changes
Nov 29, 2024
lib/src/entrypoint.dart
Outdated
| } | ||
| } | ||
| if (deletedAny) { | ||
| log.warning( | ||
| 'See https://dart.dev/go/workspaces-no-inbetween-packages for details.', |
There was a problem hiding this comment.
Suggested change
| 'See https://dart.dev/go/workspaces-no-inbetween-packages for details.', | |
| 'See https://dart.dev/go/workspace-packages-in-other-package for details.', |
I'm not sure this is better, just an idea.
There was a problem hiding this comment.
How about: https://dart.dev/go/workspaces-stray-files
There was a problem hiding this comment.
Or: https://dart.dev/go/workspaces-stray-package-configs
files covers a LOT 🤣
There was a problem hiding this comment.
I guess we are also talking pubspec.lock and pubspec.yaml
jonasfj
approved these changes
Dec 2, 2024
sigurdm
added a commit
that referenced
this pull request
Dec 3, 2024
This was referenced Dec 3, 2024
sigurdm
added a commit
that referenced
this pull request
Dec 10, 2024
sigurdm
added a commit
to sigurdm/pub
that referenced
this pull request
Dec 16, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Dec 17, 2024
Bump pub to e6704cc5219f3767ca5680ef8691c55133250664 Changes: ``` > git log --format="%C(auto) %h %s" ab8b269..e6704cc https://dart.googlesource.com/pub.git/+/e6704cc5 Don't iterate above the root dir when finding stray pubspecs (4469) https://dart.googlesource.com/pub.git/+/43c19297 Fix stray files check (4464) https://dart.googlesource.com/pub.git/+/52812073 Delete directories between workspace package and workspace root (4446) ``` Diff: https://dart.googlesource.com/pub.git/+/ab8b269..e6704cc5219f3767ca5680ef8691c55133250664/ Change-Id: Ib0eb3564b18304c1dd4626cbede359c57f253321 Cherry-pick: dart-lang/pub#4446, dart-lang/pub#4464 Cherry-pick-request: #59650 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399906 Reviewed-by: Christopher Fujino <[email protected]> Commit-Queue: Alexander Thomas <[email protected]> Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4445
Also makes resolution error if there are any pubspec.yaml's in such directories.