Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output validation errors on stdout, slightly prettier formatted #4424

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Nov 11, 2024

Moves all validation output to stdout.

I think this makes sense, because a validation error is the expected output from the validator, and what you want to process if you pipe the output. Not signifying a problem with execution of the command.

I guess this could be argued both ways. But at least having all the outputs on the same stream seems like an improvement to me.

Fixes #453 (by adding a line break between warnings)

@sigurdm sigurdm requested review from jonasfj and szakarias November 11, 2024 10:13
@sigurdm sigurdm merged commit 1dc7700 into dart-lang:master Nov 12, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve formatting of warnings from pub
3 participants