Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up duplicate lints #4407

Merged
merged 2 commits into from
Oct 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,36 +12,20 @@ analyzer:

linter:
rules:
- always_declare_return_types
- avoid_catching_errors
- avoid_print
- avoid_private_typedef_functions
- avoid_redundant_argument_values
- avoid_unused_constructor_parameters
- avoid_void_async
- cancel_subscriptions
- directives_ordering
- library_annotations
- missing_code_block_language_in_doc_comment
- missing_whitespace_between_adjacent_strings
- no_adjacent_strings_in_list
- no_runtimeType_toString
- omit_local_variable_types
- only_throw_errors
- package_api_docs
- prefer_asserts_in_initializer_lists
- prefer_const_declarations
- prefer_final_locals
- prefer_relative_imports
- prefer_single_quotes
- require_trailing_commas
- sort_pub_dependencies
- test_types_in_equals
- throw_in_finally
- type_annotate_public_apis
- unawaited_futures
- unnecessary_lambdas
- unnecessary_library_directive
- unnecessary_parenthesis
- unnecessary_statements
- unreachable_from_main
- use_enums
2 changes: 1 addition & 1 deletion lib/src/authentication/credential.dart
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import '../utils.dart';
///
/// or
///
/// /// ```json
/// ```json
/// {
/// "url": "https://example.com/",
/// "env": "TOKEN_ENV_VAR"
Expand Down
14 changes: 8 additions & 6 deletions lib/src/command/add.dart
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,8 @@ Specify multiple sdk packages with descriptors.''');
/// description is issued.
///
/// Examples:
/// ```
///
/// ```none
/// retry
/// retry:2.0.0
/// retry:^2.0.0
Expand Down Expand Up @@ -579,7 +580,8 @@ Specify multiple sdk packages with descriptors.''');
///
///
/// Examples:
/// ```
///
/// ```none
/// retry
/// retry:2.0.0
/// dev:retry:^2.0.0
Expand All @@ -593,14 +595,14 @@ Specify multiple sdk packages with descriptors.''');
/// 'retry:{"hosted":"mypub.dev"}'
/// ```
///
/// The --path --sdk and --git-<option> arguments cannot be combined with a
/// non-string descriptor.
/// The `--path`, `--sdk`, and `--git-<option>` arguments can't be
/// combined with a non-string descriptor.
///
/// If a version constraint is provided when the `--path` or any of the
/// `--git-<option>` options are used, a [usageException] will be thrown.
/// `--git-<option>` options are used, a [UsageException] will be thrown.
///
/// Packages must either be a git, hosted, sdk, or path package. Mixing of
/// options is not allowed and will cause a [usageException] to be thrown.
/// options is not allowed and will cause a [UsageException] to be thrown.
///
/// If any of the other git options are defined when `--git-url` is not
/// defined, an error will be thrown.
Expand Down
10 changes: 5 additions & 5 deletions pubspec.lock
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,10 @@ packages:
dependency: "direct dev"
description:
name: dart_flutter_team_lints
sha256: "084338b81e33917c7c180da7aaccb59a5e5d16ece372465c6a2b930841b9009a"
sha256: c6c9c89f4038a64063b67166b2d291d19697a73e111afa42ddcf1840c410c08e
url: "https://pub.dev"
source: hosted
version: "3.2.0"
version: "3.2.1"
file:
dependency: transitive
description:
Expand Down Expand Up @@ -178,10 +178,10 @@ packages:
dependency: transitive
description:
name: lints
sha256: "976c774dd944a42e83e2467f4cc670daef7eed6295b10b36ae8c85bcbf828235"
sha256: "4a16b3f03741e1252fda5de3ce712666d010ba2122f8e912c94f9f7b90e1a4c3"
url: "https://pub.dev"
source: hosted
version: "4.0.0"
version: "5.1.0"
logging:
dependency: transitive
description:
Expand Down Expand Up @@ -479,4 +479,4 @@ packages:
source: hosted
version: "2.2.1"
sdks:
dart: ">=3.5.0 <4.0.0"
dart: ">=3.6.0-0 <4.0.0"
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dependencies:

dev_dependencies:
checks: ^0.3.0
dart_flutter_team_lints: ^3.1.0
dart_flutter_team_lints: ^3.2.1
shelf_test_handler: ^2.0.2
test: ^1.24.9
test_descriptor: ^2.0.1
Expand Down
3 changes: 2 additions & 1 deletion test/help_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import 'golden_file.dart';
/// Extract all commands and subcommands.
///
/// Result will be an iterable of lists, illustrated as follows:
/// ```
///
/// ```none
/// [
/// [pub]
/// [pub, get]
Expand Down