Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert upgrade --unlock-transitive #4404

Closed
wants to merge 1 commit into from
Closed

Revert upgrade --unlock-transitive #4404

wants to merge 1 commit into from

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Oct 7, 2024

Reverts

commit a2026faf10828d79e6c0e09bca82f40cfe3eec0c (sigurdm/upgrade_unlock_transitive_deps, origin/master, origin/HEAD, upgrade_unlock_transitive_deps, master)
Author: Sigurd Meldgaard <[email protected]>
Date:   Fri Oct 4 13:18:46 2024 +0000

    Rename flag to --unlock-transitive

commit db8f497c86495410b13d701a4d4b810199b39d93
Author: Sigurd Meldgaard <[email protected]>
Date:   Thu Oct 3 14:26:03 2024 +0000

    Add flag `--transitive` to `pub upgrade`

They were landed in an incomplete state.

@sigurdm sigurdm requested a review from jonasfj October 7, 2024 10:20
jonasfj
jonasfj approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@jonasfj jonasfj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also just fix forward, I'm not sure that land+revert+reland is a better history than land+fix

@sigurdm
Copy link
Contributor Author

sigurdm commented Oct 7, 2024

Ok I'll fix forward.

@sigurdm sigurdm closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szakarias szakarias szakarias approved these changes

@jonasfj jonasfj jonasfj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sigurdm @jonasfj @szakarias