Add flag --unlock-transitive to pub upgrade
#4403
+164
−13
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| // Copyright (c) 2020, the Dart project authors. Please see the AUTHORS file | ||
| // for details. All rights reserved. Use of this source code is governed by a | ||
| // BSD-style license that can be found in the LICENSE file. | ||
|
|
||
| import 'package:test/test.dart'; | ||
|
|
||
| import '../descriptor.dart' as d; | ||
| import '../test_pub.dart'; | ||
|
|
||
| void main() { | ||
| test('without --unlock-transitive, the transitive dependencies stay locked', | ||
| () async { | ||
| final server = await servePackages(); | ||
| server.serve('foo', '1.0.0', deps: {'bar': '^1.0.0'}); | ||
| server.serve('bar', '1.0.0'); | ||
|
|
||
| await d.appDir( | ||
| dependencies: { | ||
| 'foo': '^1.0.0', | ||
| }, | ||
| ).create(); | ||
|
|
||
| await pubGet(output: contains('+ foo 1.0.0')); | ||
|
|
||
| server.serve('foo', '1.5.0', deps: {'bar': '^1.0.0'}); | ||
| server.serve('bar', '1.5.0'); | ||
|
|
||
| await pubUpgrade( | ||
| args: ['foo'], | ||
| output: allOf( | ||
| contains('> foo 1.5.0'), | ||
| isNot(contains('bar')), | ||
| ), | ||
| ); | ||
| }); | ||
|
|
||
| test('`--unlock-transitive` dependencies gets unlocked', () async { | ||
| final server = await servePackages(); | ||
| server.serve('foo', '1.0.0', deps: {'bar': '^1.0.0'}); | ||
| server.serve('bar', '1.0.0'); | ||
| server.serve('baz', '1.0.0'); | ||
|
|
||
| await d.appDir( | ||
| dependencies: { | ||
| 'foo': '^1.0.0', | ||
| 'baz': '^1.0.0', | ||
| }, | ||
| ).create(); | ||
|
|
||
| await pubGet(output: contains('+ foo 1.0.0')); | ||
|
|
||
| server.serve('foo', '1.5.0', deps: {'bar': '^1.0.0'}); | ||
| server.serve('bar', '1.5.0'); | ||
| server.serve('baz', '1.5.0'); | ||
|
|
||
| await pubUpgrade( | ||
| args: ['--unlock-transitive', 'foo'], | ||
| output: allOf( | ||
| contains('> foo 1.5.0'), | ||
| contains('> bar 1.5.0'), | ||
| isNot( | ||
| contains('baz 1.5.0'), | ||
| ), // Baz is not a transitive dependency of bar | ||
| ), | ||
| ); | ||
| }); | ||
|
|
||
| test( | ||
| '`--major-versions` without `--unlock-transitive` does not allow ' | ||
| 'transitive dependencies to be upgraded along with the named packages', | ||
| () async { | ||
| final server = await servePackages(); | ||
| server.serve('foo', '1.0.0', deps: {'bar': '^1.0.0'}); | ||
| server.serve('bar', '1.0.0'); | ||
|
|
||
| await d.appDir( | ||
| dependencies: { | ||
| 'foo': '^1.0.0', | ||
| }, | ||
| ).create(); | ||
|
|
||
| await pubGet(output: contains('+ foo 1.0.0')); | ||
|
|
||
| server.serve('foo', '2.0.0', deps: {'bar': '^1.0.0'}); | ||
| server.serve('bar', '1.5.0'); | ||
|
|
||
| await pubUpgrade( | ||
| args: ['--major-versions', 'foo'], | ||
| output: allOf( | ||
| contains('> foo 2.0.0'), | ||
| isNot(contains('bar 1.5.0')), | ||
| ), | ||
| ); | ||
| }); | ||
|
|
||
| test( | ||
| '`--unlock-transitive --major-versions` allows transitive dependencies ' | ||
| 'be upgraded along with the named packages', () async { | ||
| final server = await servePackages(); | ||
| server.serve('foo', '1.0.0', deps: {'bar': '^1.0.0'}); | ||
| server.serve('bar', '1.0.0'); | ||
| server.serve('baz', '1.0.0'); | ||
|
|
||
| await d.appDir( | ||
| dependencies: { | ||
| 'foo': '^1.0.0', | ||
| 'baz': '^1.0.0', | ||
| }, | ||
| ).create(); | ||
|
|
||
| await pubGet(output: contains('+ foo 1.0.0')); | ||
|
|
||
| server.serve('foo', '2.0.0', deps: {'bar': '^1.0.0'}); | ||
| server.serve('bar', '1.5.0'); | ||
| server.serve('baz', '1.5.0'); | ||
|
|
||
| await pubUpgrade( | ||
| args: ['--major-versions', '--unlock-transitive', 'foo'], | ||
| output: allOf( | ||
| contains('> foo 2.0.0'), | ||
| contains('> bar 1.5.0'), | ||
| isNot(contains('> baz 1.5.0')), | ||
| ), | ||
| ); | ||
| }); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.