Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use -z for git ls-files #4368

Merged
merged 6 commits into from
Sep 5, 2024

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Sep 3, 2024

This gives more reliably parsable output.

Main changes are in lib/src/validator/gitignore.dart.

Required refactor of runProcess() to not output split lines, but according to the encoding (following Process.run()).

@sigurdm sigurdm requested review from jonasfj and szakarias September 3, 2024 07:55
Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a super fan of that many casts, but maybe there is no nicer way...

lib/src/git.dart Outdated Show resolved Hide resolved
@sigurdm sigurdm requested a review from szakarias September 5, 2024 11:35
@sigurdm sigurdm merged commit c83975c into dart-lang:master Sep 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants