Migrate pub to use package:unified_analytics #4031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigurdm
approved these changes
Oct 30, 2023
| import 'dart:io'; | ||
|
|
||
| import 'package:path/path.dart' as path; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some prerequisite work for migrating package:dartdev to use package:unified_analytics.
I've removed the single analytics test here in favour of the dart pub get analytics test in dartdev for simplicity, as package:unified_analytics adds a FakeAnalytics class that tracks analytics events for easy validation in tests without needing to manually serialize all the analytics events. It's not possible to serialize / deserialize FakeAnalytics so the results can't be verified from a separate process at this point, so this testing is easier to do in dartdev. If you'd prefer we keep this testing here, please let me know if you have ideas on how to move forward 😊