Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't impose a strict size limit to uploads #4014

Merged
merged 4 commits into from
Sep 15, 2023

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Sep 13, 2023

Fix of: #4013

@sigurdm sigurdm requested a review from jonasfj September 13, 2023 14:24
Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigurdm
Copy link
Contributor Author

sigurdm commented Sep 14, 2023

When testing uploads of too large packages, the error message was not descriptive. So I added a poor person's parsing of the error messages from GCS.

PTAL.

@sigurdm sigurdm requested a review from szakarias September 14, 2023 14:39
lib/src/http.dart Outdated Show resolved Hide resolved
sigurdm and others added 2 commits September 15, 2023 10:33
Co-authored-by: Jonas Finnemann Jensen <[email protected]>
@sigurdm sigurdm merged commit 2bb8e2c into dart-lang:master Sep 15, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants