Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mention subcommand in flutter suggestion #3994

Merged
merged 4 commits into from
Sep 26, 2023
Merged

Don't mention subcommand in flutter suggestion #3994

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdac82f
Don't mention subcommand in flutter suggestion
sigurdm Aug 22, 2023
aa4f873
Fix test expectations
sigurdm Aug 24, 2023
a2e113c
Merge remote-tracking branch 'origin/master' into fix_command_suggestion
sigurdm Sep 8, 2023
187849d
Fix test expectation
sigurdm Sep 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/sdk/flutter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ class FlutterSdk extends Sdk {

@override
String get installMessage =>
'Flutter users should run `flutter pub get` instead of `dart pub get`.';
'Flutter users should use `flutter pub` instead of `dart pub`.';

@override
Version? get version {
Expand Down
3 changes: 1 addition & 2 deletions test/sdk_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,7 @@ Because myapp depends on foo from sdk which doesn't exist (unknown SDK "unknown"
Because myapp depends on foo from sdk which doesn't exist (the
Flutter SDK is not available), version solving failed.
Flutter users should run `flutter pub get` instead of `dart pub
get`.
Flutter users should use `flutter pub` instead of `dart pub`.
"""),
exitCode: exit_codes.UNAVAILABLE,
);
Expand Down
2 changes: 1 addition & 1 deletion test/testdata/goldens/hosted/fail_gracefully_with_hint_test/supports two hints.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Resolving dependencies...
[STDERR] Because foo <1.2.4 requires the Flutter SDK and foo >=1.2.4 depends on bar any, every version of foo requires bar any.
[STDERR] So, because bar doesn't exist (could not find package bar in cache) and myapp depends on foo any, version solving failed.
[STDERR]
[STDERR] Flutter users should run `flutter pub get` instead of `dart pub get`.
[STDERR] Flutter users should use `flutter pub` instead of `dart pub`.
[STDERR]
[STDERR] Try again without --offline!
[EXIT CODE] 69
Expand Down
6 changes: 3 additions & 3 deletions test/version_solver_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,7 +1283,7 @@ void sdkConstraint() {
error: equalsIgnoringWhitespace('''
Because myapp requires the Flutter SDK, version solving failed.

Flutter users should run `flutter pub get` instead of `dart pub get`.
Flutter users should use `flutter pub` instead of `dart pub`.
'''),
);
});
Expand All @@ -1304,7 +1304,7 @@ void sdkConstraint() {
Because myapp depends on foo any which requires the Flutter SDK, version
solving failed.

Flutter users should run `flutter pub get` instead of `dart pub get`.
Flutter users should run `flutter pub` instead of `dart pub`.
'''),
);
});
Expand Down Expand Up @@ -1337,7 +1337,7 @@ void sdkConstraint() {
error: equalsIgnoringWhitespace('''
Because myapp requires the Flutter SDK, version solving failed.

Flutter users should run `flutter pub get` instead of `dart pub get`.
Flutter users should run `flutter pub` instead of `dart pub`.
'''),
);
});
Expand Down