Fix pub deps behavior

dart-lang · Sep 26, 2024 · 57eb39a · 57eb39a
1 parent 23e3d4f
commit 57eb39a
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 5 deletions.
diff --git a/lib/src/command/deps.dart b/lib/src/command/deps.dart
@@ -130,8 +130,8 @@ class DepsCommand extends PubCommand {
           // before. Clients should opt to consume directDependencies and
           // devDependencies separately instead.
           'dependencies': (isRoot
-                  ? currentPackage.dependencies
-                  : currentPackage.immediateDependencies)
+                  ? currentPackage.immediateDependencies
+                  : currentPackage.dependencies)
               .keys
               .toList(),
           'directDependencies': currentPackage.dependencies.keys.toList(),

diff --git a/test/deps_test.dart b/test/deps_test.dart
@@ -158,7 +158,9 @@ void main() {
       "dependencies": [
         "normal",
         "overridden",
-        "from_path"
+        "from_path",
+        "unittest",
+        "override_only"
       ],
       "directDependencies": [
         "normal",

diff --git a/test/testdata/goldens/deps/executables_test/dev dependencies.txt b/test/testdata/goldens/deps/executables_test/dev dependencies.txt
@@ -34,7 +34,9 @@ $ pub deps --json
       "version": "0.0.0",
       "kind": "root",
       "source": "root",
-      "dependencies": [],
+      "dependencies": [
+        "foo"
+      ],
       "directDependencies": [],
       "devDependencies": [
         "foo"

diff --git a/test/workspace_test.dart b/test/workspace_test.dart
@@ -591,7 +591,8 @@ transitive dependencies:
       "source": "root",
       "dependencies": [
         "myapp",
-        "foo"
+        "foo",
+        "both"
       ],
       "directDependencies": [
         "myapp",