-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[native_toolchain_c] Add CBuilder.dynamicallyLinkTo
option
#1423
base: main
Are you sure you want to change the base?
Conversation
/// | ||
/// When using this option ensure that the builders producing the libraries | ||
/// to link to are run before this builder. | ||
final List<String> dynamicallyLinkTo; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these strings names or file paths? Please document. Also, why prefer names over paths or vice versa? (Should probably be documented in the PR description as design choice.)
], | ||
OS.windows => [ | ||
for (final library in libraries) | ||
outputDirectory.resolve('$library.lib').toFilePath(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Users might output their libs somewhere else (a subdir for example), so maybe it's better to have List<Uri> libraries
and be explicit about file paths.
If we go for file paths, then we might need to look up the name of the library for macOS/iOS/Linux/Android, unless the compiler allows file paths as well (as opposed to directory and library name.) But for those ditto, if the user compiles dylibs into a subdirectory of the target dir, the linking fails.
PR HealthBreaking changes ✔️Details
Changelog Entry ✔️Details
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️DetailsThe following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️Details
All source files should start with a license header. Unrelated files missing license headers
Package publish validation ✔️Details
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
Fixes #1419
Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.