Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[native_assets_builder] Rename Asset name to id #115

Merged
merged 7 commits into from
Aug 8, 2023
Merged

[native_assets_builder] Rename Asset name to id #115

merged 7 commits into from
Aug 8, 2023

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Aug 8, 2023

No description provided.

@dcharkes dcharkes changed the title Roll-asset-id-2 [native_assets_builder] Rename Asset name to id Aug 8, 2023
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 8, 2023
@coveralls
Copy link

coveralls commented Aug 8, 2023 •
edited
Loading

Coverage Status

coverage: 98.172% (-0.3%) from 98.458%
when pulling 36bb3fa on roll-asset-id-2
into 9ee4689 on main.

@dcharkes
Copy link
Collaborator Author

dcharkes commented Aug 8, 2023

Auto publishing seems to not work for this package: dart-lang/ecosystem#150

After running pub get locally in all subfolders, manual publishing should work.

@dcharkes dcharkes requested a review from HosseinYousefi August 8, 2023 10:02
HosseinYousefi
HosseinYousefi approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dcharkes!

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:native_assets_builder 0.2.0 ready to publish native_assets_builder-v0.2.0
package:native_toolchain_c 0.2.0 already published at pub.dev
package:native_assets_cli 0.2.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@dcharkes
Copy link
Collaborator Author

dcharkes commented Aug 8, 2023 •
edited
Loading

Thanks @HosseinYousefi !

Succeeded in making things green by:

  1. .pubignoreing the test/ directory.
  2. analysis_options.yaml exclude the test/data/ directory.

dart-lang/pub#3982 (comment)

@dcharkes dcharkes merged commit 5a1361b into main Aug 8, 2023
@dcharkes dcharkes deleted the roll-asset-id-2 branch August 8, 2023 10:36
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@mahesh-hegde
[jnigen] Add some documentation (#115)
b3f01ca
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@mahesh-hegde
[jnigen] Add some documentation (#115)
4d0a119
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
[native_assets_builder] Rename Asset name to id (#115)
fcd2610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HosseinYousefi HosseinYousefi HosseinYousefi approved these changes

Assignees
No one assigned
Labels
package:native_assets_builder package:native_assets_cli package:native_toolchain_c type-infra A repository infrastructure change or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcharkes @coveralls @HosseinYousefi