Skip to content

Commit

Permalink
add invalid_runtime_check_with_js_interop_types, unintended_html_in_d…
Browse files Browse the repository at this point in the history
…oc_comment (#285)

- add `invalid_runtime_check_with_js_interop_types`
- add `unintended_html_in_doc_comment`
- prep for publishing

The idea behind this revision is to use the above two lints for a period
of time ourselves (these lints are likely going out with the next major
revision of `package:lints` - see
https://github.com/orgs/dart-lang/projects/73).

---

- [x] I’ve reviewed the contributor guide and applied the relevant
portions to this PR.

<details>
  <summary>Contribution guidelines:</summary><br>

- See our [contributor
guide](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md)
for general expectations for PRs.
- Larger or significant changes should be discussed in an issue before
creating a PR.
- Contributions to our repos should follow the [Dart style
guide](https://dart.dev/guides/language/effective-dart) and use `dart
format`.
- Most changes should add an entry to the changelog and may need to [rev
the pubspec package
version](https://github.com/dart-lang/sdk/blob/main/docs/External-Package-Maintenance.md#making-a-change).
- Changes to packages require [corresponding
tests](https://github.com/dart-lang/.github/blob/main/CONTRIBUTING.md#Testing).

Note that many Dart repos have a weekly cadence for reviewing PRs -
please allow for some latency before initial review feedback.
</details>
  • Loading branch information
devoncarew authored Aug 8, 2024
1 parent f977423 commit 2719d0c
Show file tree
Hide file tree
Showing 5 changed files with 88 additions and 50 deletions.
123 changes: 78 additions & 45 deletions .github/workflows/dart.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions pkgs/dart_flutter_team_lints/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
## 3.1.1-wip
## 3.2.0

- Contribute a (brief) change policy to the readme.
- Contributed a (brief) change policy to the readme.
- Added `invalid_runtime_check_with_js_interop_types`.
- Added `unintended_html_in_doc_comment`.
- Require Dart `3.5`.

## 3.1.0

Expand Down
2 changes: 2 additions & 0 deletions pkgs/dart_flutter_team_lints/lib/analysis_options.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,11 @@ linter:
- avoid_dynamic_calls
- comment_references
- conditional_uri_does_not_exist
- invalid_runtime_check_with_js_interop_types
- only_throw_errors
- test_types_in_equals
- throw_in_finally
- type_annotate_public_apis
- unawaited_futures
- unintended_html_in_doc_comment
- unreachable_from_main
4 changes: 2 additions & 2 deletions pkgs/dart_flutter_team_lints/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: dart_flutter_team_lints
description: An analysis rule set used by the Dart and Flutter teams.
version: 3.1.1-wip
version: 3.2.0
repository: https://github.com/dart-lang/ecosystem/tree/main/pkgs/dart_flutter_team_lints

environment:
sdk: ^3.4.0
sdk: ^3.5.0

dependencies:
lints: ^4.0.0
Expand Down
2 changes: 1 addition & 1 deletion tool/ci.sh
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#!/bin/bash
# Created with package:mono_repo v6.6.1
# Created with package:mono_repo v6.6.2

# Support built in commands on windows out of the box.

Expand Down

0 comments on commit 2719d0c

Please sign in to comment.