Use correct interface types in linking #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrkhan
approved these changes
Mar 23, 2023
|
Not the way it is written right now no, but it is not hard to adapt it. |
satyamakgec
reviewed
Mar 23, 2023
| @@ -25,7 +26,7 @@ transaction(numBuckets: UInt64) { | |||
| acct.unlink(/public/MomentCollection) | |||
| } | |||
|
|
|||
| acct.link<&{TopShot.MomentCollectionPublic}>(/public/MomentCollection, target: /storage/ShardedMomentCollection) | |||
| acct.link<&{NonFungibleToken.Receiver, NonFungibleToken.CollectionPublic, TopShot.MomentCollectionPublic}>(/public/MomentCollection, target: /storage/ShardedMomentCollection) | |||
There was a problem hiding this comment.
Why not MetadataViews.ResolverCollection here ?
There was a problem hiding this comment.
the sharded collection doesn't implement that interface so we can't link it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The public links need to use all the types in
NonFungibleTokenandTopShotfor these purposes so they are compatible with as many 3rd party apps as possible. The Top Shot team should make sure they're following this transaction's model for linking an account