-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daphne web UI #646
base: main
Are you sure you want to change the base?
Daphne web UI #646
Conversation
I think it's a bad idea to merge it in. just my 0.02. KR, Benjamin |
Hi @aristotelis96! First of all, thanks for the awesome work on the Euro-Par demo and the web interface! Such tools on top of the DAPHNE system are great contributions to the project as they can help to demonstrate and disseminate DAPHNE. And it is a great idea to open-source these tools, along with the main system. Thanks also for initiating the discussion on where to put the code of the demo/web UI. I partly agree with @auge that the main DAPHNE repo may not be the best place for tools on top of DAPHNE. Maybe a sibling repo in Reasons to include tools in the main repo:
Reasons to host tools in separate repos:
Again, tools on top of DAPHNE are definitely a benefit for the project, but we need to decide where to put them. Any opinions and comments are welcome. |
These are just my initial thoughts on the integration of the web interface into the overall project. I haven't looked into the source code in detail yet, though ;) . |
Thank you @auge and @pdamme for your feedback! Based on your comments, I also think that maybe it's best to move this into a separate repository under @daphne-eu. We can leave this PR open for now (so others can join the discussion and make any additional improvements :) ) and I can push the final version on the new repository later. |
- Added DataService for API calls. - Updated components to use DataService instead of HttpClient service. - Changes for better error handling. - Updated API to use threads to terminate Distributed gRPC workers.
What about the repo name daphne-eu/web-ui or daphne-eu/daphne-web-ui? Anything's possible ;-) |
This is a first approach to a Daphne UI. It consists of two sub-projects, an API written in python (Flask) and a frontend web ui implemented with Angular. You can read more about how to use or extend the UI in the README files.
The UI contains a main panel used for executing Daphne and an additional "Experiments" tab which contains a few examples that were demonstrated during EuroPar2023 workshop. Users can select to run a Daphne script from the UI, the available scripts displayed can be configured through
src/tools/web-ui/backend/config.json
(read morebackend/README.md
).One major thing missing is testing (both the API and the Angular app), however I believe we can merge it for now and work on this later if we decide to extend it.
I am opening this as a pull request to open a discussion about the location of the UI within the Daphne project.
Please feel free to provide any additional comments or feedback before merging this.