-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refs #342 - do not load included files twice in CLI application / added DUI::removeComment
#340
Conversation
Still a draft as I want to research this a bit more. Sample which produces a leak (still looking at getting one with valid code): #include <//.>3=i`/\ >
88longm a
|
DUI::removeComment
DUI::removeComment
Here is a very sane looking example: #include</\\>
#include</\\>
The second memory leak from that example is fixed by #339. We should also add a testcase in Cppcheck when this hits downstream. |
DUI::removeComment
DUI::removeComment
This fixes the first memory leak from #342. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.. do you feel that this is finished?
Yes - on the CLI side this is finished. Otherwise I would have left it a draft :) |
The CLI application was pre-loading the included files just to remove the comments. Adding a
DUI
option for that makes it necessary. This makes profiling with the CLI more useful and it also fixes a potential memory leak in the CLI when an empty (or currently also non-existent) include was specified.