Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert valueflow split #6991

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

pfultz2
Copy link
Contributor

@pfultz2 pfultz2 commented Nov 5, 2024

Revert most of the moving passes out of valueflow.cpp. Splitting up valueflow should be organized differently.

@pfultz2
Copy link
Contributor Author

pfultz2 commented Nov 8, 2024

The error in CI is unrelated to this PR, and is a failure with getting qt packages on windows:

INFO    : aqtinstall(aqt) v3.1.18 on Python 3.11.9 [CPython MSC v.1938 64 bit (AMD64)]
WARNING : Specified Qt version "6.7.3" did not exist when this version of aqtinstall was released. This may not install properly, but we will try our best.
WARNING : Specified target combination "windows desktop win64_msvc2022_64" did not exist when this version of aqtinstall was released. This may not install properly, but we will try our best.
ERROR   : The packages ['qt_base', 'qtcharts'] were not found while parsing XML of package information!
==============================Suggested follow-up:==============================
* Please use 'aqt list-qt windows desktop --arch 6.7.3' to show architectures available.
* Please use 'aqt list-qt windows desktop --modules 6.7.3 <arch>' to show modules available.

@pfultz2
Copy link
Contributor Author

pfultz2 commented Nov 9, 2024

This same failure is on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant