Fix #13216: Add checkers-report block to xml output #6914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase and drop the stray bad commit. |
|
The bad commit is still there. That needs to be dropped from the branch. |
danmar
reviewed
Oct 15, 2024
|
We should add a test which generates the output and validates the XML. I am not sure where to add that since the existing targets only test static files and not the results of the CLI. As that would require the Having a RNG would be the icing on the cake. |
danmar
reviewed
Oct 16, 2024
danmar
reviewed
Oct 16, 2024
danmar
reviewed
Oct 21, 2024
danmar
approved these changes
Oct 22, 2024
|
We should document what the differences between version 2 and 3 are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.