Add QT_USE_NAMESPACE macro #6864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro `QT_USE_NAMESPACE` should expand to nothing for most Qt builds, i.e. built with an empty `QT_NAMESPACE` variable.
bjornblissing
force-pushed
the
QT_NAMESPACE
branch
from
3f05e78
to
2712724
Compare
ludviggunne
pushed a commit
to ludviggunne/cppcheck
that referenced
this pull request
Oct 19, 2024
The macro `QT_USE_NAMESPACE` should expand to nothing for most Qt builds, i.e. built with an empty `QT_NAMESPACE` variable. However if Qt is built using a custom namespace then all forward declarations must be wrapped with `QT_BEGIN_NAMESPACE` and `QT_END_NAMESPACE`. Today CppCheck defines these macros as empty, thus `QT_USE_NAMESPACE` should be empty as well. Reference: https://wiki.qt.io/Qt_In_Namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macro
QT_USE_NAMESPACEshould expand to nothing for most Qt builds, i.e. built with an emptyQT_NAMESPACEvariable.However if Qt is built using a custom namespace then all forward declarations must be wrapped with
QT_BEGIN_NAMESPACEandQT_END_NAMESPACE. Today CppCheck defines these macros as empty, thusQT_USE_NAMESPACEshould be empty as well.Reference:
https://wiki.qt.io/Qt_In_Namespace