Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValueFlow: extracted valueFlowSwitchVariable() into separate file #6783

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Sep 8, 2024

No description provided.

@chrchr-github
Copy link
Collaborator

vf_reverse.cpp only has one small function now. Does this make sense?

@firewave
Copy link
Collaborator Author

firewave commented Sep 9, 2024

vf_reverse.cpp only has one small function now. Does this make sense?

It pulls in things which are not necessary in other cases so technically it does. It seems excessive right now and it tries to help making head and tails of stuff (since the forward stuff is so much more complicated I was surprised the reverse stuff is that light). This looks very much like something which could moved somewhere else afterwards.

@firewave
Copy link
Collaborator Author

firewave commented Sep 9, 2024

On a side note I still have a smaller and a really big one almost ready locally but I will delay them until several of my existing PRs have been processed which are actually more important than this...also the amount of open PRs is getting ridiculous.

@chrchr-github
Copy link
Collaborator

chrchr-github commented Sep 9, 2024

...also the amount of open PRs is getting ridiculous.

True. We should probably clean up at least the stalled PRs that are >X months/years old. But there are also 80+ draft PRs...

@firewave firewave merged commit c348128 into danmar:main Sep 26, 2024
63 checks passed
@firewave firewave deleted the vf-switchvar branch September 26, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants