fixed #13066 - Makefile: need to use override when appending to variable specified on the command-line
#6765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iable specified on the command-line see https://www.gnu.org/software/make/manual/make.html#Override-Directive
|
#4968 (comment) mentions that you should not use There are other places where this should be added but I refrained from that as it might introduce issues instead of fixing them. This should be properly addressed after #4968 has been merged. I will also prepare a backport after this was merged. |
|
No feedback in over two weeks - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://www.gnu.org/software/make/manual/make.html#Override-Directive