Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestIO: added missing testing of Win32W #6728

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

Discovered while working on #6044.

Still a draft as it is possible that more individual tests need to be added.

@firewave firewave changed the title TestIO: added testing of Win32W TestIO: added missing testing of Win32W Aug 28, 2024
@firewave
Copy link
Collaborator Author

Still a draft as it is possible that more individual tests need to be added.

Since Win32W is just about UNICODE=1 I do not think additional tests are necessary. The ones I added might not be necessary as well but the actual test cases are obscured (generated) we should lean on the safe side and still test it.

@firewave firewave marked this pull request as ready for review September 19, 2024 10:03
@chrchr-github chrchr-github merged commit 437558d into danmar:main Sep 24, 2024
63 checks passed
@firewave firewave deleted the testio-win32w branch September 24, 2024 12:54
ludviggunne pushed a commit to ludviggunne/cppcheck that referenced this pull request Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants