Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12943 FP knownConditionTrueFalse with lambda in if condition #6714

Merged
merged 5 commits into from
Aug 21, 2024

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

@danmar
Copy link
Owner

danmar commented Aug 21, 2024

Thanks for working on this! hmm I would like to update that ticket title somehow.

@danmar
Copy link
Owner

danmar commented Aug 21, 2024

Could you change the title somehow from the text "Lambda confuses boolean test" I have no idea what it means. "Confuse" could mean anything false positives, false negatives, crashes, ...

Can you imagine something more specific?

From your fix it looks like the symboldatabase did not create the scope for a lambda inside if condition properly?

@chrchr-github chrchr-github changed the title Fix #12943 Lambda confuses boolean test Fix #12943 FP knownConditionTrueFalse with lambda in if condition Aug 21, 2024
@chrchr-github
Copy link
Collaborator Author

Could you change the title somehow from the text "Lambda confuses boolean test" I have no idea what it means. "Confuse" could mean anything false positives, false negatives, crashes, ...

Can you imagine something more specific?

From your fix it looks like the symboldatabase did not create the scope for a lambda inside if condition properly?

Yes. I have changed the titles of the ticket and the PR accordingly.

@chrchr-github chrchr-github marked this pull request as ready for review August 21, 2024 15:53
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chrchr-github chrchr-github merged commit 0a11422 into danmar:main Aug 21, 2024
63 checks passed
@chrchr-github chrchr-github deleted the chr_12943 branch August 21, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants