avoid using temporary objects in followAllReferences()

[firewave]

No description provided.

[firewave]

-D__GNUC__ --check-level=exhaustive ../lib/utils.cpp

Clang 17 727,573,266 -> 722,149,127
GCC 14 773,604,329 -> 764,052,021

The example from https://trac.cppcheck.net/ticket/10765#comment:4:

Clang 17 3,785,661,648 -> 3,745,218,741
GCC 14 4,083,156,774 -> 4,013,339,574

[chrchr-github]

How far away are we from activating modernize-use-emplace?

[firewave]

How far away are we from activating modernize-use-emplace?

It is enabled. This was not detected because the object could not be created without the missing constructor - see https://godbolt.org/z/MK1a9eG5h.

The fix-it will lead to broken code though. I will file a ticket later on.

[chrchr-github]

Using the compiler-generated constructor requires C++20 (but there still won't be a warning for the original code):
https://godbolt.org/z/fdcaT3rx3

[firewave]

The fix-it will lead to broken code though. I will file a ticket later on.

I filed llvm/llvm-project#104565 about that.