refs #12080 - testrunner: do not create test implementation until it is used #6691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are some redundancies and it could probably be solved in a cleaner way but it is not intrusive at all. |
firewave
force-pushed
the
test-instance
branch
from
7b45586
to
7e17729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greatly improves the start-up time because it no longer needs to create all the implementations before it runs any test.
The following times are using a debug build.
Before:
bin/testrunner TestColor 1,16s user 0,07s system 99% cpu 1,235 totalAfter:
bin/testrunner TestColor 0,00s user 0,00s system 88% cpu 0,009 total