Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refs #12080 - testrunner: do not create test implementation until it is used #6691

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

firewave
Copy link
Collaborator

Greatly improves the start-up time because it no longer needs to create all the implementations before it runs any test.

The following times are using a debug build.

Before: bin/testrunner TestColor 1,16s user 0,07s system 99% cpu 1,235 total

After: bin/testrunner TestColor 0,00s user 0,00s system 88% cpu 0,009 total

@firewave
Copy link
Collaborator Author

There are some redundancies and it could probably be solved in a cleaner way but it is not intrusive at all.

@firewave firewave marked this pull request as ready for review August 14, 2024 07:58
@chrchr-github chrchr-github merged commit f39f567 into danmar:main Aug 14, 2024
63 checks passed
@firewave firewave deleted the test-instance branch August 14, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants