Fix #12989: Honor attribute cleanup in unusedFunction #6656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mptre
force-pushed
the
attribute-cleanup
branch
from
4e16bfa
to
6f8f9a7
Compare
chrchr-github
changed the title
| { | ||
| check("void clean(void *ptr) {}\n" | ||
| "void * __attribute__((cleanup(clean))) p;\n"); | ||
| ASSERT_EQUALS("", errout_str()); |
There was a problem hiding this comment.
The example compiles but results in
<source>:2:27: warning: 'cleanup' attribute only applies to local variables [-Wignored-attributes]
2 | void * __attribute__((cleanup(clean))) p;
But it probably doesn't matter for the test.
Gets rid of FPs when a static function is only used with the attribute cleanup.
mptre
force-pushed
the
attribute-cleanup
branch
from
6f8f9a7
to
d690b9b
Compare
|
On Tue, Aug 06, 2024 at 02:58:07AM -0700, chrchr-github wrote:
The example compiles but results in
~~~
<source>:2:27: warning: 'cleanup' attribute only applies to local variables [-Wignored-attributes]
2 | void * __attribute__((cleanup(clean))) p;
~~~
But it probably doesn't matter for the test.
Right, fixed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets rid of FPs when a static function is only used with attribute cleanup.