Fix #12974 FN functionConst with std::as_const()

[chrchr-github]

No description provided.

[chrchr-github]

std::move is not pure in e.g. MSVC STL or libstdc++:
https://github.com/gcc-mirror/gcc/blob/ed03af4ef3b9ad0bd3b7c5c678c02253e5cb9e0f/libstdc%2B%2B-v3/include/bits/move.h#L123

[pfultz2]

std::move is not pure in e.g. MSVC STL or libstdc++:

It is marked with constexpr which makes it pure(since constexpr functions cannot rely on global state). Furthermore the implementation of std::move which is just a static_cast is pure as well.

Is there an issue with it being pure that you see?

[chrchr-github]

Is there an issue with it being pure that you see?

Yes: https://github.com/danmar/cppcheck/actions/runs/10196381651/job/28207045014
It is probably easier to treat std::move as if it modifies its argument as opposed to tracking what happens to its return value.