Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made TestTokenizerCompileLimits not heavy at all #6587

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

This limit is obviously not fully helping with the previous example. I will file a ticket about that later.

@firewave
Copy link
Collaborator Author

I somehow didn't bother with moving it back into TestTokenizer. I might do that when I update the costs in a later PR.

@firewave
Copy link
Collaborator Author

Another test also fails:

FAILED performance_test.py::test_crash_array_in_namespace - Failed: Timeout >20.0s

@chrchr-github
Copy link
Collaborator

Another test also fails:

FAILED performance_test.py::test_crash_array_in_namespace - Failed: Timeout >20.0s

Seems like issues with MacOS runners are well known, but why the recent slowdown?
actions/runner-images#3885
actions/runner-images#1336
actions/runner-images#8434

@firewave
Copy link
Collaborator Author

The performance of the macOS runners has always been quite inconsistent. But maybe we also introduced some slowdowns. I have not been paying attention to the performance because there are just too many bugs I have been looking into.

@chrchr-github
Copy link
Collaborator

Daca execution times haven't changed much:

Time for all packages (not just the ones listed above):
Total time:                                           619799.5   635130.8       1.02

@chrchr-github chrchr-github merged commit ba29f83 into danmar:main Jul 11, 2024
63 checks passed
@firewave firewave deleted the compileliomit-2 branch July 12, 2024 06:05
@firewave
Copy link
Collaborator Author

That's a 2% regression on average which means that certain packages might have bigger regressions. Looking at a few packages I see several which have regressed quite but not enough to be listed in our default report which only starts at double times. reducing the factor shows a lot more packages: http://cppcheck1.osuosl.org:8000/time_gt.html?factor=1.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants