Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #12837 - do not use empty filename in FileWithDetails in GUI (fixes cppcheck-gui crash) #6523

Merged
merged 2 commits into from
Jun 17, 2024
Merged

fixed #12837 - do not use empty filename in FileWithDetails in GUI (fixes cppcheck-gui crash) #6523

merged 2 commits into from
Jun 17, 2024

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave
Copy link
Collaborator Author

The new code is very much identical to what we do in ThreadExecutor. I wanted to share that code in the past but that would require CLI-only code to be moved into lib which I want to avoid. We probably need a small additional lib which contains frontend-only code as there is other code which needs to be share but does not really belong into lib.

@chrchr-github chrchr-github merged commit 1c35930 into danmar:main Jun 17, 2024
63 checks passed
@firewave firewave deleted the gui-fs-crash branch June 17, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@firewave @chrchr-github