-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #8159 FN unusedFunction: sole recursive call #6517
Conversation
@@ -180,7 +181,7 @@ class TestUnusedFunctions : public TestFixture { | |||
" if (cond) ;\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add the missing cond
variable when fixing this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - too late.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cond
could be an unknown global variable.
The return2()
test is not compilable though.
Do we want to keep |
The logic was apparently moved to simplecpp in 03d2829 shortly after it was added in 3095f47. So we should remove it.
Add suppressions for these for now with comments which indicate how they are (not) used. |
We have a bunch of code that deals with "markup files". Is this tested explicitly anywhere? |
That is tested in |
I see, thanks. That's one of the reasons for using strings to identify functions instead of |
No description provided.