Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12383: cppcheck build dir: changed line numbers in source file #6505

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

olabetskyi
Copy link
Collaborator

I added comparison of both lines and columns so if any exta spaces/new lines were added we can adjus our report accordingly

@firewave
Copy link
Collaborator

Please add a test for this.

lib/preprocessor.cpp Outdated Show resolved Hide resolved
@olabetskyi olabetskyi marked this pull request as ready for review June 11, 2024 11:24
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@olabetskyi olabetskyi merged commit ea2c390 into danmar:main Jun 11, 2024
63 checks passed
@olabetskyi olabetskyi deleted the lines_fix branch June 11, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants