Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit usage of internal in selfchecks to files which are being matchcompiled #6473

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Jun 1, 2024

No description provided.

@firewave
Copy link
Collaborator Author

firewave commented Jun 1, 2024

There is actually a check which is not dependent on the matchcompiler. checkRedundantNextPrevious() will detect redundant patterns when working on tokens. But I think it should be fine since such code is not being used outside of lib and I think there is no need to apply it to the test code.

@firewave firewave merged commit 3edeccb into danmar:main Jul 29, 2024
63 checks passed
@firewave firewave deleted the selfcheck-internal branch July 29, 2024 12:17
@firewave
Copy link
Collaborator Author

Splitting cli from lib in the scanning has the unfortunately side effect that the selfcheck is now busy with cli/cmdlineparser.cpp which is the longest file and will no longer process the lib files on the other process. That causes the selfcheck to be slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants