fixed #12763 - do not assert in markup processing for unusedFunction when a language is enforced
#6425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
commented
May 23, 2024
| @@ -68,7 +68,8 @@ class CPPCHECKLIB TokenList { | |||
| /** @return true if the code is C++ */ | |||
| bool isCPP() const; | |||
|
|
|||
| void setLang(Standards::Language lang); | |||
| // TODO: get rid of this | |||
| void setLang(Standards::Language lang, bool force = false); | |||
There was a problem hiding this comment.
This function is just a hack. The only other user is the Clang import because our unit tests use data in an incomplete format.
Also all this logic and asserts will (hopefully) go away when we perform the file identification early on for all input instead of on-demand when it is tokenized.
danmar
approved these changes
May 23, 2024
firewave
changed the title
unusedFunction when a language is enforcedunusedFunction when a language is enforced
firewave
added a commit
to firewave/cppcheck
that referenced
this pull request
May 23, 2024
…` when a language is enforced (danmar#6425) (cherry picked from commit 9c21862)
danmar
pushed a commit
to cppchecksolutions/cppcheck
that referenced
this pull request
May 26, 2024
…` when a language is enforced (danmar#6425)
danmar
pushed a commit
to cppchecksolutions/cppcheck
that referenced
this pull request
May 26, 2024
…` when a language is enforced (danmar#6425)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.