Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12761 (SymbolDatabase: two structs with same name, constructor added to the wrong struct in the SymbolDatabase) #6424

Merged
merged 2 commits into from
May 23, 2024

Conversation

danmar
Copy link
Owner

@danmar danmar commented May 23, 2024

No description provided.

…dded to the wrong struct in the SymbolDatabase)
Copy link
Owner Author

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the behavior so different template scopes are not "merged" or "reused".

@@ -5658,12 +5659,12 @@ class TestSymbolDatabase : public TestFixture {
"};\n"
"const S S::IN(1);\n");
ASSERT(db);
ASSERT_EQUALS(6, db->scopeList.size());
ASSERT_EQUALS(7, db->scopeList.size());
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have double checked that 11444 problems are not shown again.

@@ -5611,7 +5612,7 @@ class TestSymbolDatabase : public TestFixture {
"static const int foo = 8;\n"
"}\n");
ASSERT(db);
ASSERT_EQUALS(6, db->scopeList.size());
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have double checked that the duplInheritedMember etc are not shown again that was supposed to be fixed when this test was added.

@danmar danmar merged commit f066778 into danmar:main May 23, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant