Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate failing scriptcheck using Python 3.5 #6396

Merged
merged 1 commit into from
May 11, 2024
Merged

Conversation

chrchr-github
Copy link
Collaborator

No description provided.

@chrchr-github chrchr-github merged commit 1943b4d into main May 11, 2024
63 checks passed
@chrchr-github chrchr-github deleted the chr_py35 branch May 11, 2024 13:12
@firewave
Copy link
Collaborator

firewave commented May 11, 2024

Thanks for fixing this. I will be out indefinitely (hopefully just short-term) so I cannot be on top of things which I usually am.

The error in question for future reference:

 Resolved as '3.5.10'
  Version 3.5.10 was not found in the local cache
  Version 3.5.10 is available for downloading
  Download from "https://github.com/actions/python-versions/releases/download/3.5.10-90026/python-3.5.10-linux-20.04-x64.tar.gz"
  Extract downloaded archive
  /usr/bin/tar xz --warning=no-unknown-keyword -C /home/runner/work/_temp/fd6e504a-5d65-4a53-8af6-528b89f647c6 -f /home/runner/work/_temp/0a40308e-571c-4848-91d3-bb2eada06c9c
  Execute installation script
  Check if Python hostedtoolcache folder exist...
  Create Python 3.5.10 folder
  Copy Python binaries to hostedtoolcache folder
  Create additional symlinks (Required for the UsePythonVersion Azure Pipelines task and the setup-python GitHub Action)
  Upgrading PIP...
  Requirement already satisfied: setuptools in /opt/hostedtoolcache/Python/3.5.10/x64/lib/python3.5/site-packages
  Requirement already satisfied: pip in /opt/hostedtoolcache/Python/3.5.10/x64/lib/python3.5/site-packages
  Collecting pip
  Could not fetch URL https://pypi.python.org/simple/pip/: There was a problem confirming the ssl certificate: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:728) - skipping
  Error: Could not find a version that satisfies the requirement pip (from versions: )
  Error: No matching distribution found for pip
  Error: The process '/usr/bin/bash' failed with exit code 1

Python 3.5 has been EOL since September 2020 so it is not surprising that the certificates might be outdated. Further Python versions which are EOL and might run into something similar in the future are 3.6 (December 2021) and 3.7 (June 2023).

We might want to extend the scriptcheck job to run on docker images with older Python versions. Will file a ticket about that later.

firewave pushed a commit to firewave/cppcheck that referenced this pull request May 15, 2024
@firewave
Copy link
Collaborator

We might want to extend the scriptcheck job to run on docker images with older Python versions. Will file a ticket about that later.

As those jobs require a binary it would increase the run-time as we would have to create that for each platform so I wonder have feasible that is as we still need to reduce the run-time of the CI and should not add to it.

chrchr-github added a commit that referenced this pull request May 15, 2024
(cherry picked from commit 1943b4d)

Co-authored-by: chrchr-github <[email protected]>
firewave pushed a commit to firewave/cppcheck that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants