Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #12726: Update for CheckOrderEvaluation #6393

Merged
merged 7 commits into from
May 20, 2024

Conversation

olabetskyi
Copy link
Collaborator

No description provided.

lib/checkother.cpp Outdated Show resolved Hide resolved
lib/checkother.cpp Outdated Show resolved Hide resolved
test/testother.cpp Outdated Show resolved Hide resolved
@olabetskyi olabetskyi changed the title Update for CheckOrderEvaluation Fix #12726: Update for CheckOrderEvaluation May 13, 2024
@olabetskyi olabetskyi marked this pull request as ready for review May 13, 2024 13:39
lib/checkother.cpp Outdated Show resolved Hide resolved
lib/checkother.cpp Outdated Show resolved Hide resolved
lib/checkother.cpp Show resolved Hide resolved
Copy link
Owner

@danmar danmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. I feel that we should run test-my-pr a little on this..

@danmar
Copy link
Owner

danmar commented May 20, 2024

looks good to me. I feel that we should run test-my-pr a little on this..

After running test-my-pr.py we think the results do look good. I did not see any false positive.

@olabetskyi olabetskyi merged commit 9d4d118 into danmar:main May 20, 2024
63 checks passed
@olabetskyi olabetskyi deleted the checkEvaluatingOrder branch May 20, 2024 07:46
danmar pushed a commit to cppchecksolutions/cppcheck that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants