-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #12699 QDir functions missing from qt.cfg #6374
Conversation
Co-authored-by: Dominik Strasser <[email protected]>
Having an unknown mail address is probably not good. So maybe we should not use that field. |
<not-bool/> | ||
</arg> | ||
</function> | ||
<!-- bool QDir::path() const --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this comment wrong it says that QDir::path returns bool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest <use-retval/>
Yes, the comment is a copy-paste error. The failing regressions come from the fact that I fixed the function name of QDir::exists which used to be only "QDir". |
Do you want to take this over? |
I can try. What I do not understand is the errors we are seeing. Maybe I have not yet understood the library config. This - according to my understanding - specifies the two functions from the comments as they are like one function with a default parameter. The regression tests fail with: why are the function calls not regarded as matched ? And why is the use-retval ignored ? It is almost as if the whole entry is ignored whereas it seems to have worked before when the entry was bogus as it had Ah, now I see it. The regressions are about QFile::exists |
I think we now have only |
My bad. I misread it. I'll provide a new qt.cfg + qt.cpp |
Please feel free to open your own PR. |
Co-authored-by: Dominik Strasser [email protected]